[U-Boot] [PATCH] EXT4

[Jorgen Lundman]

> Yes, that is exactly what you should do.
>
> But before you post them, make sure you run them through checkpatch.pl
> first and resolve/explain any errors or warnings

Wow, ohhweee this will take a little while.

How set in stone is the output of checkpatch.pl ? Specifically;

ERROR: do not initialise globals to 0 or NULL
#596: FILE: fs/zfs/zfs.c:33:
+block_dev_desc_t *zfs_dev_desc = NULL;

That strikes me as dangerous. One lets you fail gracefully (Sorry, X has 
not been initialised) and the other is just a plain crash. I find crashes 
to be very ugly, even if it is only reachable by other developers.




WARNING: do not add new typedefs
#728: FILE: fs/zfs/zfs.c:165:
+typedef struct decomp_entry

I'm seriously not allowed to make new typedefs? ouch.


So yeah, should it always pass without a single problem, or may I employ 
some measure of moderation?




-- 
Jorgen Lundman       | <lundman at lundman.net>
Unix Administrator   | +81 (0)3 -5456-2687 ext 1017 (work)
Shibuya-ku, Tokyo    | +81 (0)90-5578-8500          (cell)
Japan                | +81 (0)3 -3375-1767          (home)