[U-Boot] [PATCH 2/2] zfs: Add ZFS filesystem support

[Graeme Russ]

Hi Jorgen,

On Wed, May 23, 2012 at 1:11 PM, Jorgen Lundman <lundman at lundman.net> wrote:
>
>
>> What are all these commit references? Are they from an external git-repo?
>> If so I think the commit message might make more sense if you simply
>> summarise what you have done to adapt the original source code in order to
>> integrate it into U-Boot
>
>
> Hmm I assumed --squash would git rid of that history, I guess not. I'll find
> a way.
>
>
>> Please keep list sorted
>
>
> I didn't even notice it was sorted. Of course this leave the issue of:
>
> COBJS-$(CONFIG_YAFFS2) += cmd_yaffs2.o
> COBJS-$(CONFIG_CMD_ZFS) += cmd_zfs.o
> COBJS-$(CONFIG_CMD_SPL) += cmd_spl.o
>
> Not sure if I was supposed to go before or after that dangling spl.

Have a patch that sorts the list then add zfs :)

>> This looks to be an unrelated change - If needed, move this into a
>> seperate
>> patch
>
>
> Actually, git noticed I copied the ../Makefile and changed it for
> zfs/Makefile. That's pretty neat.

Thats OK - It just looked odd


> Once I test compile and compliance again, I will resend for your scrutiny.

Best to wait a couple of days - I'm sure there will be other comments

And don't forget to rev you patch series and add revision notes below the ---

Regards,

Graeme