[U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

[Wolfgang Denk]

Dear Marek Vasut,

In message <1337729574-30475-1-git-send-email-marex at denx.de> you wrote:
> These targets allow for easy invocation of mxstool, for generating
> the u-boot images bootable in mx28 CPU.

Thanks.

> +$(obj)u-boot.mx28.sd:  $(obj)u-boot.sb
> +		$(obj)tools/mxsboot sd $(obj)u-boot.sb $(obj)u-boot.mx28.sd
> +
> +$(obj)u-boot.mx28.nand: $(obj)u-boot.sb
> +		$(obj)tools/mxsboot nand $(obj)u-boot.sb $(obj)u-boot.mx28.nand

There are rules missing to clean up these new images when make clean /
make distclean is used.

Why do we need this special "mx28" part in the name?   I don't see how
this would be useful, but it hurts as you will have to add a (probably
growing) list uf targets to the remove lists. - what's wrong with just
calling these "u-boot.bin.sd" and "u-boot.bin.nand" ?

Would it not be useful to automatically build these images when
someone runs just "make -j8 -s m28evk" (or "./MAKEALL m28evk") ?


Also, I'm a bit surprised about the restrictive permissions of the
resulting images:

-rw-------   1 wd wd  464320 May 23 11:09 u-boot.mx28.sd
-> umask
0002

This should be fixed (probably in tools/mxsboot0 ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
People have one thing in common: they are all different.