[U-Boot] [PATCH v3 15/21] net: cosmetic: Add a more explicit comment about 802.2
Joe Hershberger
joe.hershberger at ni.com
Wed May 23 19:58:11 CEST 2012
Make the comment more accurate about the header including SNAP
Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
Cc: Joe Hershberger <joe.hershberger at gmail.com>
---
Changes for v2:
- Split from "Improve variable names and code readability"
- Fixed comment indention
Changes for v3:
- Added a short commit message
include/net.h | 4 ++--
net/net.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/net.h b/include/net.h
index ff66073..730af4f 100644
--- a/include/net.h
+++ b/include/net.h
@@ -179,11 +179,11 @@ struct e802_hdr {
ushort et_prot; /* 802 protocol */
};
-/* 802 ethernet header size */
+/* 802 + SNAP + ethernet header size */
#define E802_HDR_SIZE (sizeof(struct e802_hdr))
/*
- * Ethernet header
+ * Virtual LAN Ethernet header
*/
struct vlan_ethernet_hdr {
uchar vet_dest[6]; /* Destination node */
diff --git a/net/net.c b/net/net.c
index b8a267c..1293688 100644
--- a/net/net.c
+++ b/net/net.c
@@ -898,7 +898,8 @@ NetReceive(uchar *inpkt, int len)
if (x < 1514) {
struct e802_hdr *et802 = (struct e802_hdr *)et;
/*
- * Got a 802 packet. Check the other protocol field.
+ * Got a 802.2 packet. Check the other protocol field.
+ * XXX VLAN over 802.2+SNAP not implemented!
*/
x = ntohs(et802->et_prot);
--
1.6.0.2
More information about the U-Boot
mailing list