[U-Boot] [PATCH V4 1/4] ARM: Define change_bit routine
Amit Virdi
amit.virdi at st.com
Thu May 24 06:18:14 CEST 2012
Hi Wolfgang,
On 5/22/2012 9:21 PM, Wolfgang Denk wrote:
> Dear Amit Virdi,
>
> In message<4FBB6712.3040005 at st.com> you wrote:
>>
>> Alright, I shall be soon sending V5 that drops this patch and uses
>> __change_bit directly.
>
> It would be a much better investment in time if you come up with
> patches that help to _avoid_ usign this horrible function, and
> eventually removig it from U-Boot.
>
> change_bit() is inherently not portable and actual behaviour is
> largely undefined, so please do NOT use this function in any new code.
>
Ok. I have understood your point. I would resend V5 excluding any call
to __change_bit.
Thanks
Amit Virdi
More information about the U-Boot
mailing list