[U-Boot] [PATCH 1/3] tegra: usb: Add USB support to Tamonten boards

[Thierry Reding]

* Stephen Warren wrote:
> On 05/24/2012 01:04 AM, Thierry Reding wrote:
> > This adds basic USB support for port 0. Device tree support is needed to
> > initialize the USB EHCI and will be added in a subsequent patch.
> 
> I don't think this is anything in particular to do with USB support "for
> port 0"; it's general USB support.

Okay, I did copy this from Simon's earlier commits. I can just drop "for port
0". It isn't really relevant anyway.

> The code here duplicates changes made to board/nvidia/common/board.c.
> Shouldn't all Tegra boards be using that common board code so we don't
> have to duplicate all this early setup for every board vendor using
> Tegra? Otherwise, every time we add I2C, SPI, LP0, ... to
> board/nvidia/common/board.c, you'll just have to make the same change to
> tamonten.c too.

I think the problem is U-Boot's build system, which doesn't allow sharing
code between different subdirectories of board/.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120524/d5e2f235/attachment.pgp>