[U-Boot] [PATCH 2/3] tegra: medcom: Add device tree support

[Thierry Reding]

* Stephen Warren wrote:
> On 05/24/2012 01:04 AM, Thierry Reding wrote:
> > Device tree support is required for working USB host support, which in
> > turn enables ethernet support.
> 
> > diff --git a/board/avionic-design/dts/tegra2-medcom.dts b/board/avionic-design/dts/tegra2-medcom.dts
> 
> > +	chosen {
> > +		bootargs = "console=ttyS0,115200n8";
> > +	};
> 
> I don't think you need that in the U-Boot .dts file, since it's specific
> to the kernel. Admittedly, U-Boot's tegra2-seaboard.dts has it, but none
> of the other Tegra .dts files do.

Okay, I'll drop it.

> > +	sdhci at c8000600 {
> > +		cd-gpios = <&gpio 58 0>; /* gpio PH2 */
> > +		wp-gpios = <&gpio 59 0>; /* gpio PH3 */
> > +	};
> 
> I'd prefer not to include SDHCI nodes in the U-Boot .dts files, since
> U-Boot doesn't support configuring the SDHCI controllers from device
> tree (yet?). Having these nodes exist before then would be misleading.
> Yes again, the seaboard .dts file has it, but it should probably be
> removed from there too.

I'll drop that as well, then. Do you want me to prepare a patch to remove
those nodes from the Seaboard DTS?

> > diff --git a/include/configs/medcom.h b/include/configs/medcom.h
> 
> > +/* USB networking support */
> > +#define CONFIG_USB_HOST_ETHER
> > +#define CONFIG_USB_ETHER_SMSC95XX
> > +#define CONFIG_USB_ETHER_ASIX
> 
> Is there an SMSC95XX on the board? Since standalone dongles with that
> chipset are rare, we've removed that one config option from all the
> other Tegra boards since it likely isn't useful (except Harmony which
> has that chip on board).

Yes, the Tamonten has an SMSC95XX.

> Aside from those comments, this looks fine.

Thanks for reviewing.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120524/64b993bd/attachment.pgp>