[U-Boot] [PATCH] Kirkwood: declare mpp config static and const

Michael Walle michael at walle.cc
Mon May 28 23:45:25 CEST 2012


Hi Luka,

Am Sonntag 27 Mai 2012, 23:20:29 schrieb Luka Perkov:
> NACK. At least in this version. Please double check all the kirkwood
> boards (taken from boards.cfg):

ups sorry, actually my tree wasn't up to date :( pogo_e02 is missing, too.


> diff --git a/board/raidsonic/ib62x0/ib62x0.c
> b/board/raidsonic/ib62x0/ib62x0.c index 65f2c2e..f888901 100644
> --- a/board/raidsonic/ib62x0/ib62x0.c
> +++ b/board/raidsonic/ib62x0/ib62x0.c
> @@ -42,7 +42,7 @@ int board_early_init_f(void)
>  			IB62x0_OE_LOW, IB62x0_OE_HIGH);
> 
>  	/* Multi-Purpose Pins Functionality configuration */
> -	u32 kwmpp_config[] = {
> +	static const kwmpp_config[] = {

this should be static const u32 kwmpp_config[] = {

> Also you should note that this patch should be applied after your
> patches for lsxl board.
ah yes, thanks.

-- 
Michael


More information about the U-Boot mailing list