[U-Boot] [PATCH 3/3] tegra: usb: fix wrong error check

Tom Warren twarren.nvidia at gmail.com
Wed May 30 01:20:35 CEST 2012


Lucas,

On Tue, May 29, 2012 at 3:18 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 05/29/2012 03:47 PM, Lucas Stach wrote:
>> Just stumbled upon this, while looking through the usb code. loop_count
>> runs down from 10000, so the correct condition to error out is ==0.
>
> The code change is probably fine, but it'd be better if the commit
> description stated just what was being changed and why, rather than
> being conversational.
>
> Acked-by: Stephen Warren <swarren at wwwdotorg.org>

In addition, I'd like to see come comment in the commit msg about what
HW this was tested on, what was done to test it, etc.

Tom


More information about the U-Boot mailing list