[U-Boot] [PATCH 2/2] tegra: usb: fix wrong error check

Marek Vasut marek.vasut at gmail.com
Thu May 31 15:14:53 CEST 2012


Dear Lucas Stach,

> loop_count runs down from 10000, so the correct condition to error out
> is ==0.
> 
> Signed-off-by: Lucas Stach <dev at lynxeye.de>
> Acked-by: Stephen Warren <swarren at wwwdotorg.org>
> CC: Stephen Warren <swarren at wwwdotorg.org>
> CC: Tom Warren <twarren.nvidia at gmail.com>
> ---
>  arch/arm/cpu/armv7/tegra2/usb.c |    2 +-
>  1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
> 
> diff --git a/arch/arm/cpu/armv7/tegra2/usb.c
> b/arch/arm/cpu/armv7/tegra2/usb.c index c80de7f..5f2b243 100644
> --- a/arch/arm/cpu/armv7/tegra2/usb.c
> +++ b/arch/arm/cpu/armv7/tegra2/usb.c

Why isn't this file in drivers/usb/ ?

> @@ -290,7 +290,7 @@ static int init_usb_controller(struct fdt_usb *config,
>  			break;
>  		udelay(1);
>  	}
> -	if (loop_count == 100000)
> +	if (!loop_count)
>  		return -1;
> 
>  	return 0;

Best regards,
Marek Vasut


More information about the U-Boot mailing list