[U-Boot] [PATCH v4 6/6] tegra: Enable NAND on Seaboard

[Simon Glass]

Hi,

On Thu, Nov 1, 2012 at 4:13 PM, Lucas Stach <dev at lynxeye.de> wrote:
> Am Donnerstag, den 01.11.2012, 15:57 -0600 schrieb Stephen Warren:
>> On 07/30/2012 12:53 AM, Simon Glass wrote:
>> > This enables NAND support for the Seaboard.
>>
>> > diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
>>
>> >  #include "tegra20-common-post.h"
>> >
>> > +/* NAND support */
>> > +#define CONFIG_CMD_NAND
>> > +#define CONFIG_TEGRA_NAND
>> > +
>> > +/* Max number of NAND devices */
>> > +#define CONFIG_SYS_MAX_NAND_DEVICE 1
>> > +
>> > +/* Somewhat oddly, the NAND base address must be a config option */
>> > +#define CONFIG_SYS_NAND_BASE       TEGRA20_NAND_BASE
>>
>> Simon, I just noticed that all these config options are added after the
>> include of tegra20-common-post.h. That file should be included at the
>> very end in case it needs to do something different based on the
>> board-specific configuration. I don't suppose you could move those lines
>> before the include?
>
> Also CONFIG_SYS_NAND_BASE is not really used in the current Tegra nand
> controller codebase, in fact you can get away with not defining it. We
> should probably use this define in our driver code, but then we should
> add this define to some common Tegra place and not to individual board
> files.

OK I will look at these next week.

Regards,
Simon

>
> Regards,
> Lucas
>
>