[U-Boot] [PATCH V1 5/5] imximage.cfg: run files through C preprocessor

Stefano Babic sbabic at denx.de
Sat Nov 10 08:23:49 CET 2012


On 23/10/2012 22:57, Troy Kisky wrote:
> The '#' used as comments in the files cause the preprocessor
> trouble, so change to /* */.
> 
> Signed-off-by: Troy Kisky <troy.kisky at boundarydevices.com>
> ---


Hi Troy,

>  .gitignore                                   |    1 +
>  Makefile                                     |   11 +-
>  board/esg/ima3-mx53/imximage.cfg             |  120 ++++++-----
>  board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg |   90 ++++----
>  board/freescale/mx25pdk/imximage.cfg         |   77 +++----
>  board/freescale/mx51evk/imximage.cfg         |  114 +++++-----
>  board/freescale/mx53ard/imximage_dd3.cfg     |   83 ++++----
>  board/freescale/mx53evk/imximage.cfg         |   86 ++++----
>  board/freescale/mx53loco/imximage.cfg        |   83 ++++----
>  board/freescale/mx53smd/imximage.cfg         |   83 ++++----
>  board/freescale/mx6qarm2/imximage.cfg        |   88 ++++----
>  board/freescale/mx6qsabreauto/imximage.cfg   |   82 +++----
>  board/genesi/mx51_efikamx/imximage_mx.cfg    |  132 ++++++------
>  board/genesi/mx51_efikamx/imximage_sb.cfg    |  126 +++++------
>  board/ttcontrol/vision2/imximage_hynix.cfg   |  295 ++++++++++++++------------
>  15 files changed, 777 insertions(+), 694 deletions(-)
> 

I am not sure. I see that Tom agree using /* comment style, but I have
not seen a general agreement where to move the rule (in which Makefile,
I mean). Tom, is it ok for you to add the rule in the main Makefile ?

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list