[U-Boot] [PATCH] ehci-mxc: Fix host power mask bit for i.MX35

[Stefano Babic]

On 16/11/2012 12:42, Benoît Thébaudeau wrote:
> The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance
> selection bit.
> 
> This issue has been reported by Michael Burkey <mdburkey at gmail.com> and fixed by
> Christoph Fritz <chf.fritz at googlemail.com> on Linux, from which these #define-s
> had been copied.
> 
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau at advansee.com>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Marek Vasut <marex at denx.de>

Hi Benoit,

> ---
>  .../drivers/usb/host/ehci-mxc.c                                      |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> index 7c5f71c..f2642a0 100644
> --- u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c
> +++ u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> @@ -67,7 +67,7 @@
>  #define MX35_H1_SIC_SHIFT	21
>  #define MX35_H1_SIC_MASK	(0x3 << MX35_H1_SIC_SHIFT)
>  #define MX35_H1_PP_BIT		(1 << 18)
> -#define MX35_H1_PM_BIT		(1 << 8)
> +#define MX35_H1_PM_BIT		(1 << 16)
>  #define MX35_H1_IPPUE_UP_BIT	(1 << 7)
>  #define MX35_H1_IPPUE_DOWN_BIT	(1 << 6)
>  #define MX35_H1_TLL_BIT		(1 << 5)

Hey, the patch was sent today to linux-arm ! Very nice you noted and
route the bug to u-boot.

Acked-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================