[U-Boot] [PATCH 2/4] mx5: Print CSPI clock in 'clock' command

Stefano Babic sbabic at denx.de
Fri Nov 16 14:18:45 CET 2012


On 16/11/2012 12:15, Fabio Estevam wrote:
> Hi Dirk,
> 
> On Fri, Nov 16, 2012 at 4:35 AM, Dirk Behme <dirk.behme at gmail.com> wrote:
> 
>> I wondered if we want something similar for i.MX6, too. And found that we
>> have this on i.MX6, already. But without #ifdef.
>>
>> http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/mx6/clock.c;h=a01d96f48e04377d705b7a587ec7b3ea59aee283;hb=HEAD#l407
>>
>> Do we want to add the #ifdef for i.MX6, too? Or would it be nicer to drop
>> the #ifdef in this patch to make i.MX6 and i.MX5 equal?
> 
> The reason I added the ifdef was to avoid showing the cspi clock on a
> board that does not use cspi. This would help
> not 'polluting' the clock command output.
> 

Agree. Boards that do not support SPI can have a completely wrong value,.

Regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list