[U-Boot] [PATCH 01/10] usb: Remove obsolete header file
Lukasz Majewski
l.majewski at samsung.com
Wed Nov 28 17:01:24 CET 2012
Hi Tom,
> Hi Pantelis,
>
> > usbdescriptors.h conflicts with linux/usb/ch9.h
> > Remove it.
>
After rebasing on u-boot-usb/next below comment apply:
After applying this patch, I cannot build trats target anymore.
With u-boot-usb/master I can compile the u-boot for trats board with no
warnings and errors.
Unfortunately after flashing with dfu, the u-boot is _NOT_ working
properly anymore.
It seems, that some parts of the binary weren't correct.
> It writes u-boot.bin, but in a way that the board is bricked after
> flashing.
I need some time to perform the thorough review of core DFU patches
(patches 7/10, 09/10, 10/10).
> BTW:
> 1. What is your target device? What is the output of dfu mmc 0 list
> command on your device?
>
> On trats it is:
> DFU alt settings list:
> dev: eMMC alt: 0 name: u-boot layout: RAW_ADDR
> dev: eMMC alt: 1 name: uImage layout: FAT
>
> 2. Please look into the TRATS board (especially the CONFIG_DFU_ALT
> constant) for reference.
>
> 3. What is yours dfu-util version? (Mine is 0.1+svnexported)
>
> >
> > Signed-off-by: Pantelis Antoniou <panto at antoniou-consulting.com>
> > ---
> > drivers/usb/gadget/f_dfu.c | 1 -
> > include/g_dnl.h | 1 -
> > 2 files changed, 2 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
> > index 3ec4c65..10547e3 100644
> > --- a/drivers/usb/gadget/f_dfu.c
> > +++ b/drivers/usb/gadget/f_dfu.c
> > @@ -25,7 +25,6 @@
> > #include <malloc.h>
> >
> > #include <linux/usb/ch9.h>
> > -#include <usbdescriptors.h>
> > #include <linux/usb/gadget.h>
> > #include <linux/usb/composite.h>
> >
> > diff --git a/include/g_dnl.h b/include/g_dnl.h
> > index 0ec7440..f47395f 100644
> > --- a/include/g_dnl.h
> > +++ b/include/g_dnl.h
> > @@ -22,7 +22,6 @@
> > #define __G_DOWNLOAD_H_
> >
> > #include <linux/usb/ch9.h>
> > -#include <usbdescriptors.h>
> > #include <linux/usb/gadget.h>
> >
> > int g_dnl_register(const char *s);
>
>
>
--
Best regards,
Lukasz Majewski
Samsung Poland R&D Center | Linux Platform Group
More information about the U-Boot
mailing list