[U-Boot] [PATCH 01/10] usb: Remove obsolete header file

[Pantelis Antoniou]

Hi Lukasz,

On Nov 28, 2012, at 6:01 PM, Lukasz Majewski wrote:

> Hi Tom,
> 
>> Hi Pantelis,
>> 
>>> usbdescriptors.h conflicts with linux/usb/ch9.h
>>> Remove it.
>> 
> After rebasing on u-boot-usb/next below comment apply:
> 
> After applying this patch, I cannot build trats target anymore.
> 
> 
> With u-boot-usb/master I can compile the u-boot for trats board with no
> warnings and errors.
> 
> Unfortunately after flashing with dfu, the u-boot is _NOT_ working
> properly anymore.
> It seems, that some parts of the binary weren't correct.
> 

Are you writing to a file in a filesystem? I.e. FAT?

I'm in the middle of doing more extensive tests, but file write to an
FS might have problems. I am using the raw mmc interface.

There could be something there that it's missed. I'm in the middle of
doing more extensive tests.


>> It writes u-boot.bin, but in a way that the board is bricked after
>> flashing.
> 
> I need some time to perform the thorough review of core DFU patches
> (patches 7/10, 09/10, 10/10).
> 

OK.

> 
> 
>> BTW: 
>> 1. What is your target device? What is the output of dfu mmc 0 list
>> command on your device?
>> 

I'm on am335x_evm target, actual board is a beaglebone.


>> On trats it is:
>> DFU alt settings list:
>> dev: eMMC alt: 0 name: u-boot layout: RAW_ADDR
>> dev: eMMC alt: 1 name: uImage layout: FAT
>> 

# setenv dfu_alt_info 'test part 0 3'
# mmc part
U-Boot# mmc part

Partition Map for MMC device 0  --   Partition Type: DOS

Part    Start Sector    Num Sectors     UUID            Type
  1     63              112392          7a348599-01     0c Boot
  2     112455          7501331         7a348599-02     83
  3     7613786         12966           7a348599-03     83
# dfu mmc 0 list
DFU alt settings list:
dev: eMMC alt: 0 name: test layout: RAW_ADDR

Are you downloading u-boot.bin to the raw nand?
I.e. there's no boot partition?

All my tests have been downloading a small ext3 image to the mmc.
I'm in the middle of doing more extensive tests but those takes a huge
amount of time... :(

>> 2. Please look into the TRATS board (especially the CONFIG_DFU_ALT
>> constant) for reference.
>> 

Already looked there.

>> 3. What is yours dfu-util version? (Mine is 0.1+svnexported)
>> 

Compiled from source git://gitorious.org/dfu-util/dfu-util.git
Current master.

Regards

-- Pantelis


>>> 
>>> Signed-off-by: Pantelis Antoniou <panto at antoniou-consulting.com>
>>> ---
>>> drivers/usb/gadget/f_dfu.c | 1 -
>>> include/g_dnl.h            | 1 -
>>> 2 files changed, 2 deletions(-)
>>> 
>>> diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
>>> index 3ec4c65..10547e3 100644
>>> --- a/drivers/usb/gadget/f_dfu.c
>>> +++ b/drivers/usb/gadget/f_dfu.c
>>> @@ -25,7 +25,6 @@
>>> #include <malloc.h>
>>> 
>>> #include <linux/usb/ch9.h>
>>> -#include <usbdescriptors.h>
>>> #include <linux/usb/gadget.h>
>>> #include <linux/usb/composite.h>
>>> 
>>> diff --git a/include/g_dnl.h b/include/g_dnl.h
>>> index 0ec7440..f47395f 100644
>>> --- a/include/g_dnl.h
>>> +++ b/include/g_dnl.h
>>> @@ -22,7 +22,6 @@
>>> #define __G_DOWNLOAD_H_
>>> 
>>> #include <linux/usb/ch9.h>
>>> -#include <usbdescriptors.h>
>>> #include <linux/usb/gadget.h>
>>> 
>>> int g_dnl_register(const char *s);
>> 
>> 
>> 
> 
> 
> 
> -- 
> Best regards,
> 
> Lukasz Majewski
> 
> Samsung Poland R&D Center | Linux Platform Group