[U-Boot] [PATCH v4 1/8] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear Łukasz Dałek,

> On 02.10.2012 21:35, Marek Vasut wrote:
> > Dear Lukasz Dalek,
> > 
> >> Add basic support for HP iPAQ h2200 palmtop. h2200 palmtop was targeted
> >> to general consumers. It has 64 MB of RAM, 32 MB flash. No intergrated
> >> Wi-Fi nor Ethernet. Based on Intel PXA255 processor. It was shipped with
> >> Windows CE 4.2 operating system.
> >> 
> >> Signed-off-by: Lukasz Dalek<luk0104 at gmail.com>
> >> ---
> >> 
> >>   board/h2200/Makefile       |   51 ++++++++++++++
> >>   board/h2200/h2200-header.S |   27 ++++++++
> >>   board/h2200/h2200.c        |   53 +++++++++++++++
> >>   boards.cfg                 |    1 +
> >>   include/configs/h2200.h    |  156
> >> 
> >> ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 288
> >> insertions(+), 0 deletions(-)
> >> 
> >>   create mode 100644 board/h2200/Makefile
> >>   create mode 100644 board/h2200/h2200-header.S
> >>   create mode 100644 board/h2200/h2200.c
> >>   create mode 100644 include/configs/h2200.h
> > 
> > Will you please learn to write patch changelog ?
> 
> I will, I promise.
> 
> >> diff --git a/board/h2200/Makefile b/board/h2200/Makefile
> >> new file mode 100644
> >> index 0000000..2265aa9
> >> --- /dev/null
> >> +++ b/board/h2200/Makefile
> >> @@ -0,0 +1,51 @@
> >> +#
> >> +# h2200 Support
> >> +#
> >> +# Copyright (C) 2012 Lukasz Dalek<luk0104 at gmail.com>
> >> +#
> >> +# This program is free software; you can redistribute it and/or
> >> +# modify it under the terms of the GNU General Public License as
> >> +# published by the Free Software Foundation; either version 2 of
> >> +# the License, or (at your option) any later version.
> >> +#
> >> +# This program is distributed in the hope that it will be useful,
> >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >> +# GNU General Public License for more details.
> >> +#
> >> +# You should have received a copy of the GNU General Public License
> >> +# along with this program; if not, write to the Free Software
> >> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> >> +# MA 02111-1307 USA
> >> +#
> >> +
> >> +include $(TOPDIR)/config.mk
> >> +
> >> +LIB	= $(obj)lib$(BOARD).o
> >> +
> >> +COBJS	:= h2200.o
> >> +
> >> +SRCS	:= $(COBJS:.o=.c) h2200-header.S
> >> +OBJS	:= $(addprefix $(obj),$(COBJS))
> >> +
> >> +ALL: $(LIB) h2200-header.bin
> >> +
> >> +h2200-header.o: h2200-header.S
> >> +	$(CC) $(CFLAGS) -c -o $@ $<
> > 
> > Try building with BUILD_DIR=<somewhere>  ./MAKEALL h2200
> 
> what toolchain do you recommend? I use codesourcery and it complains
> about some enums.

http://www.denx.de/wiki/DULG/ELDK or debian toolchains

> > hint: you're missing $(obj) all around here so the resulting files are
> > still in the source tree, not the BUILD_DIR, which is wrong of course.
> 
> Can you recommend board which has proper Makefile?

All of them should, did you detect such problem elsewhere?

> 
> Łukasz Dałek

Best regards,
Marek Vasut