[U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard

[Stephen Warren]

On 09/27/2012 06:44 PM, Simon Glass wrote:
> This series adds support for the Tegra2x's display peripheral. This
> supports the LCD display on Seaboard and we use this to enable console
> output in U-Boot on the LCD.

I tested this on Seaboard, and found a couple of minor issues:

1) Nothing sets up the environment to enable LCD output; I had to execute:

setenv stdout serial,lcd

... in order to see anything on the display. I'd expect patch 16/16 to
cause this to happen automatically?

It's probably best to fix this by revising patch 16 rather than later,
since I presume this is trivial to fix?

2) The display works fine for cold boot, or hitting the physical reset
button, but when I execute "reset" at the U-Boot prompt, or "reboot"
within Linux, the display is messed up; it looks like the LCD isn't able
to sync to the timings sent by the display controller or something similar.

Since this is slightly a corner case, it may be OK to fix it later (but
not much later; reboot is very useful to me.)


I'll provide review comments on the patches themselves later.