[U-Boot] [PATCH 1/2] ext4: Rename block group descriptor table from gd to bgd

[Simon Glass]

Hi Tom,

On Wed, Oct 3, 2012 at 1:49 PM, Tom Rini <trini at ti.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/03/12 13:40, Simon Glass wrote:
>> Hi Tom,
>>
>> On Wed, Oct 3, 2012 at 1:04 PM, Tom Rini <trini at ti.com> wrote: On
>> 10/03/12 12:53, Simon Glass wrote:
>>
>>>>> On x86 machines gd is unfortunately a #define, so we should
>>>>> avoid using gd for anything. This patch changes uses of gd to
>>>>> bgd so that ext4fs can be used on x86.
>>>>>
>>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>
>>> Is there any way to change x86 to not be using a #define for gd?
>>
>> I wasn't brave enough to look hard at that, although Graeme is on
>> copy and will know. It is actually using inline assembly to access
>> this special variable.
>
> Yeah, I took a quick stab at it myself earlier and didn't make it
> work.  We need to fix this for the release.  My concern was "we must
> share this with the kernel" but, we don't (I realized as I was
> drafting this reply).  So I'm more OK with taking the change now than
> I was at first, but if we can not #define gd that will help prevent
> the problem from popping up in the future.

Yes - if there is a fix for the x86 gd implementation then we could
skip this patch (or perhaps revert it later if the fix is really
complicated). Still, I think the patch should be harmless.

Unfortunately thought there are a few errors in the patches, so I will resend.

Regards,
Simon

>
> - --
> Tom
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJQbKTnAAoJENk4IS6UOR1WJCEP/35rXvf/aAastlgJz5R/RCdM
> PNfOqJrfladuRW8BcQBE2wjRR3V1D7O61AboDQmnwCuknEX+NZhEgDcTWQFBw93o
> p8A0OKOMjWyMWtoJgwcTuvnJqRLaldqGyvcBaRv8X0uPYw9OJObIAmVb9n/tx6X3
> i2kN0bfoPDGCgvEYm2ygXGyjvAGJ5A+5W/Cxsd+nGdjUGEBgS4q1GqEA24H++NAG
> pQLo2r59pjd6IzjzHeDqPRImi9Cu5seiajjkA34fGwxZY06wreSokaut/WiTIMwb
> VsYyZX6OXLcKmz2SbC8haY5FabgmF8bvkNJUMh4wMX02O3h09cOU25cWBjl0D3Lz
> rfVl9sQwuyXEx5WAo0GK18wa/rt9q0mRDgaBfPeFNPoLa4lZuUZE9qEKtidX9A+G
> aRjECVmCJYEq14atSqKZzeB1EshU066mN9y1XlV5B0/N95gztElQDkArFiuBmYXh
> vhGvduxmR33W0EizhbZH9w53eTittKfa83GwV+SwVnYXxrytWiMPDYJzjaJ3pAcC
> sxuTW65GcRbm5AEUpY3+8Uozdu7m00jGeCMi1pya+UqTam5gFVm7ee2g6PpdL2p3
> mUi5cVHU58IuQdxhZqM2Omk5ptzHh23oPR0JdiG2kUoVLt3KZn9HmST9yUrLT/DP
> pJ+twKTqC6YDqyLsfcDM
> =Zfek
> -----END PGP SIGNATURE-----