[U-Boot] [PATCH] arm: rmobile: bugfix: wrong register saving in lowlevel_init

[Jeroen Hofstee]

Hello All,

On 10/07/2012 01:34 PM, Enric Balletbò i Serra wrote:
> Hi Albert,
>
> 2012/10/5 Albert ARIBAUD <albert.u.boot at aribaud.net>:
>> Hi Tetsuyuki,
>>
>> On Fri,  5 Oct 2012 13:39:22 +0900, Tetsuyuki Kobayashi
>> <koba at kmckk.co.jp> wrote:
>>
>>> lowlevel_init() of rmobile badly assumed that ip register holds return address.
>>> The commit "63ee53a7 armv7 cpu_init_crit: Simplify code" breaks this assumption.
>>> This patch removes this bad assumption and simplify code.
>>>
>>> Signed-off-by: Tetsuyuki Kobayashi <koba at kmckk.co.jp>
>>> ---
>>>
>> ...
> Note that the patch that Tetsuyuki says also breaks SPL support for
> OMAP3 boards, at least my IGEP boards doesn't boot and hangs at SPL
> level.
>
>    U-Boot SPL 2012.10-rc1-00244-g28e5ac2 (Oct 07 2012 - 13:11:29)
>
> Bisecting the problem I encountered the problem is the commit
> "63ee53a7 armv7 cpu_init_crit: Simplify code".
>
> Cheers,
>      Enric
>
I can confirm above. Also the tam3517 som (omap3) fails to boot due to
mentioned commit. The patch from Tetsuyuki is arch specific (rmobile) so
that won't fix the omap case. Reverting the patch, 63ee53a, does help.

Is there anything against reverting the patch (at least for the release...)?

Regards,
Jeroen