[U-Boot] [PATCH] disk: get_device_and_partition() return value fixes
Stephen Warren
swarren at wwwdotorg.org
Mon Oct 8 19:45:54 CEST 2012
From: Stephen Warren <swarren at nvidia.com>
When no valid partitions are found, guarantee that we return -1. This
most likely already happens, since the most recent get_partition_info()
will have returned an error. However, it's best to be explicit.
Remove an unnecessary assignment of ret=0 in the success case; this value
is over-written with the processed partition ID later.
Signed-off-by: Stephen Warren <swarren at nvidia.com>
---
Tom, this probably makes sense to go into the release, although I don't
think it's critical.
disk/part.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/disk/part.c b/disk/part.c
index 3022969..a0c77dd 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -624,9 +624,9 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,
*/
if (p == MAX_SEARCH_PARTITIONS + 1)
*info = tmpinfo;
- ret = 0;
} else {
printf("** No valid partitions found **\n");
+ ret = -1;
goto cleanup;
}
}
--
1.7.0.4
More information about the U-Boot
mailing list