[U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

[Troy Kisky]

On 10/7/2012 11:19 AM, Eric Nelson wrote:
> Hi Troy,
>
> On 10/03/2012 06:47 PM, Troy Kisky wrote:
>> The '#' used as comments in the files cause the preprocessor
>> trouble, so change to /* */.
>>
>> Signed-off-by: Troy Kisky<troy.kisky at boundarydevices.com>
>> ---
>>   Makefile                                     |    3 +-
>>   board/esg/ima3-mx53/imximage.cfg             |  120 ++++++-----
>>   board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg |   90 ++++----
>>   board/freescale/mx25pdk/imximage.cfg         |   77 +++----
>>   board/freescale/mx51evk/imximage.cfg         |  114 +++++-----
>>   board/freescale/mx53ard/imximage_dd3.cfg     |   83 ++++----
>>   board/freescale/mx53evk/imximage.cfg         |   86 ++++----
>>   board/freescale/mx53loco/imximage.cfg        |   83 ++++----
>>   board/freescale/mx53smd/imximage.cfg         |   83 ++++----
>>   board/freescale/mx6qarm2/imximage.cfg        |   88 ++++----
>>   board/genesi/mx51_efikamx/imximage_mx.cfg    |  132 ++++++------
>>   board/genesi/mx51_efikamx/imximage_sb.cfg    |  126 +++++------
>>   board/ttcontrol/vision2/imximage_hynix.cfg   |  295 
>> ++++++++++++++------------
>>   13 files changed, 727 insertions(+), 653 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index a40d4cc..64ff1b8 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -431,7 +431,8 @@ $(obj)u-boot.img:    $(obj)u-boot.bin
>>           -d $<  $@
>>
>>   $(obj)u-boot.imx:       $(obj)u-boot.bin
>> -        $(obj)tools/mkimage -n  $(CONFIG_IMX_CONFIG) -T imximage \
>> +        $(CC) -E -x c $(CONFIG_IMX_CONFIG) -I./include -o 
>> $(obj)imxcfg.imx
>> +        $(obj)tools/mkimage -n  $(obj)imxcfg.imx -T imximage \
>>           -e $(CONFIG_SYS_TEXT_BASE) -d $<  $@
>
> This bit creates imxcfg.imx.
>
> If built in-tree, the file will be reported as a new file in 'git 
> status'.
> Is there a reason it can't be deleted after the build?
>
Just being able to look at it to see that the output makes sense.
I should make sure that make clean, deletes it, but I kinda like being
able to look at it after a make all.
Is an entry in gitignore ok?

Is everyone OK was the file name imxcfg.imx, or should some other 
extension be used?