[U-Boot] [PATCH 2/2] spi: Add SPI flash test

[Tom Rini]

On Mon, Oct 08, 2012 at 04:00:08PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, Oct 1, 2012 at 10:32 AM, Tom Rini <trini at ti.com> wrote:
> > On Fri, Sep 28, 2012 at 05:28:01PM -0700, Simon Glass wrote:
> >
> >> It is useful to have a basic SPI flash test, which tests that the SPI chip,
> >> the SPI bus and the driver are behaving.
> >>
> >> This test erases part of the flash, writes data and reads it back as a
> >> sanity check that all is well.
> >>
> >> Use CONFIG_SF_TEST to enable it.
> >>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> ---
> >>  README          |    5 ++
> >>  common/cmd_sf.c |  160 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  2 files changed, 165 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/README b/README
> >> index 5793b0a..8f601ae 100644
> >> --- a/README
> >> +++ b/README
> >> @@ -2309,6 +2309,11 @@ The following options need to be configured:
> >>               CONFIG_SF_DEFAULT_MODE          (see include/spi.h)
> >>               CONFIG_SF_DEFAULT_SPEED         in Hz
> >>
> >> +             CONFIG_CMD_SF_TEST
> >> +
> >> +             Define this option to include a destructive SPI flash
> >> +             test ('sf test').
> >> +
> >
> > Lets make this note as well that it is of course a destructive test.
> 
> Do you mean change the comment?

Um.  I had reading comprehension issues that morning.  I can see right
now that it says it's destructive.

> > [snip]
> >> +static int do_spi_flash_test(void)
> >> +{
> >> +     /* TODO(sjg at chromium.org): Support cmdline parameters for these */
> >
> > Lets just add that now? :)  Thanks.
> 
> Fair enough, will do.

Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121008/ffb4608d/attachment.pgp>