[U-Boot] [PATCH] FEC: Rework RX buffer init

Albert ARIBAUD albert.u.boot at aribaud.net
Fri Oct 12 13:08:18 CEST 2012


Hi Marek,

On Wed, 10 Oct 2012 00:43:33 +0200, Marek Vasut <marex at denx.de> wrote:

> Rework the RX buffer init so that it's easier to understand.
> Firstly, allocate the whole RX buffer as one large continuous
> piece of memory. Also, drop all these writel() accessors used
> on the FEC RX DMA descriptor, since it's all flat bogus.

I'd like this commit message to be more usefully descriptive than "all
flat bogus". What exactly is bogus in it?

> Finally, this makes recoverable stalls of the FEC on i.MX28
> disappear completely.

Are both the single allocation change and the writel() change needed
for this?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list