[U-Boot] [PATCH v3 1/5] arm bootm: Allow to pass board specified atags

Pali Rohár pali.rohar at gmail.com
Sun Oct 14 02:02:16 CEST 2012


On Sunday 14 October 2012 01:43:25 Marek Vasut wrote:
> Dear Pali Rohár,
> 
> ... missing commit message ...
> 

Is not subject enought?

> > Signed-off-by: Pali Rohár <pali.rohar at gmail.com>
> > ---
> > 
> >  arch/arm/include/asm/setup.h |    5 +++++
> >  arch/arm/lib/bootm.c         |    5 +++++
> >  2 files changed, 10 insertions(+)
> 
> ... missing changelog ...
> 

There is no changelog. This patch is new in v3. I wrote it in 
mail [PATCH v3 0/5].

> > diff --git a/arch/arm/include/asm/setup.h
> > b/arch/arm/include/asm/setup.h index 89df4dc..78a7fac 100644
> > --- a/arch/arm/include/asm/setup.h
> > +++ b/arch/arm/include/asm/setup.h
> > @@ -267,3 +267,8 @@ struct meminfo {
> > 
> >  extern struct meminfo meminfo;
> >  
> >  #endif
> > 
> > +
> > +/*
> > + * Board specified tags
> > + */
> 
> What's this ?
> 

Function which allow to pass board specified (non standard) 
atags. It is what you suggested:
http://www.mail-archive.com/u-boot@lists.denx.de/msg82803.html

> > +void setup_board_tags(struct tag **in_params);
> > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> > index a9070d5..c092bfa 100644
> > --- a/arch/arm/lib/bootm.c
> > +++ b/arch/arm/lib/bootm.c
> > @@ -266,6 +266,10 @@ static int create_fdt(bootm_headers_t
> > *images)> 
> >  }
> >  #endif
> > 
> > +void __setup_board_tags(void) {}
> > +void setup_board_tags(struct tag **in_params)
> > +	__attribute__((weak, alias("__setup_board_tags")));
> 
> __weak void setup...(...) {} works just fine. Include
> linux/compiler.h

I did not know about __weak. I will change it.

-- 
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121014/af760316/attachment.pgp>


More information about the U-Boot mailing list