[U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

Marek Vasut marex at denx.de
Sun Oct 14 02:17:01 CEST 2012


Dear Pali Rohár,

> On Sunday 14 October 2012 01:45:06 Marek Vasut wrote:
> > >  	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
> > > 
> > > +		if (bd->bi_dram[i].size == 0)
> > > +			continue;
> > 
> > This doesn't look right at all, your board is misconfigured if
> > bd->bi_dram[i] == 0. Did you misconfigure CONFIG_NR_DRAM_BANKS
> > ?
> 
> On some N900 devices there are two banks and on some only one. If
> there is only one it has size 256 MB and if there are two both
> has 128 MB. CONFIG_NR_DRAM_BANKS must be specified at compile
> time, but for N900 I need runtime detection.

How can that be? Are these two banks contiguous?

Best regards,
Marek Vasut


More information about the U-Boot mailing list