[U-Boot] [PATCH 31/32] drivers/mtd/nand: sparse fixes

Kim Phillips kim.phillips at freescale.com
Wed Oct 17 02:28:47 CEST 2012


nand_ecc.c:82:5: warning: symbol 'nand_calculate_ecc' was not declared. Should it be static?
nand_ecc.c:155:5: warning: symbol 'nand_correct_data' was not declared. Should it be static?
nand_base.c:2854:1: error: directive in argument list
nand_base.c:2856:1: error: directive in argument list

Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
---
 drivers/mtd/nand/nand_base.c | 9 +++++----
 drivers/mtd/nand/nand_ecc.c  | 1 +
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 71f5027..110cebd 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2849,12 +2849,13 @@ ident_done:
 
 	/* TODO onfi flash name */
 	MTDDEBUG (MTD_DEBUG_LEVEL0, "NAND device: Manufacturer ID:"
-		" 0x%02x, Chip ID: 0x%02x (%s %s)\n", *maf_id, *dev_id,
-		nand_manuf_ids[maf_idx].name,
+		" 0x%02x, Chip ID: 0x%02x (%s", *maf_id, *dev_id,
+		nand_manuf_ids[maf_idx].name);
 #ifdef CONFIG_SYS_NAND_ONFI_DETECTION
-		chip->onfi_version ? chip->onfi_params.model : type->name);
+	MTDDEBUG (MTD_DEBUG_LEVEL0, " %s)\n", chip->onfi_version ?
+		  chip->onfi_params.model : type->name);
 #else
-		type->name);
+	MTDDEBUG (MTD_DEBUG_LEVEL0, " %s)\n", type->name);
 #endif
 
 	return type;
diff --git a/drivers/mtd/nand/nand_ecc.c b/drivers/mtd/nand/nand_ecc.c
index 81f0e08..097cf62 100644
--- a/drivers/mtd/nand/nand_ecc.c
+++ b/drivers/mtd/nand/nand_ecc.c
@@ -39,6 +39,7 @@
 
 #include <asm/errno.h>
 #include <linux/mtd/mtd.h>
+#include <linux/mtd/nand_ecc.h>
 
 /* The PPC4xx NDFC uses Smart Media (SMC) bytes order */
 #ifdef CONFIG_NAND_NDFC
-- 
1.7.12.3




More information about the U-Boot mailing list