[U-Boot] [U-Boot, V2, 1/9] disk: part_efi: remove indent level from loop

Stephen Warren swarren at wwwdotorg.org
Wed Oct 17 18:04:13 CEST 2012


On 10/17/2012 09:01 AM, Tom Rini wrote:
> On Mon, Oct 08, 2012 at 08:14:32AM -0000, Stephen Warren wrote:
> 
>> From: Stephen Warren <swarren at nvidia.com>
>> 
>> Simplify the partition printing loop in print_part_efi() to bail
>> out early when the first invalid partition is found, rather than
>> indenting the whole body of the loop. This simplifies later
>> patches.
>> 
>> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> 
> This, along with the rest of the series have been applied to 
> u-boot/master, thanks!  Note that for 9/9 I had to rework it
> slightly to take the new output formatting, can you please double
> check?  Thanks!

Thanks. The results looks fine; there is zero diff between my local
branch and u-boot/master on the files that series touched.

I wonder if the rework you needed to do was because patch 8/9 wasn't
applied? I did do some cleanup of the printf strings in that patch
separately, but there isn't an equivalent commit in your tree; it's as
if 8/9 and 9/9 were squashed into one.

BTW, I had also posted a minor fix "disk: initialize name/part fields
when returning a whole disk" which may have been overlooked? Perhaps
it's still in your queue.

Thanks.


More information about the U-Boot mailing list