[U-Boot] [PATCH 1/6 V4] common: Add symbol handling for generic lists into Makefile

[Marek Vasut]

Dear Tom Rini,

> On Fri, Oct 19, 2012 at 03:19:19PM +0200, Marek Vasut wrote:
> > Dear Wolfgang Denk,
> > 
> > [...]
> > 
> > > Maybe we can sae one call to objdump by storing the intermediate
> > > result?
> > 
> > I removed the other call in subsequent patch anyway, so this is fine now.
> > 
> > > > +		cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) \
> > > > +			$$UNDEF_SYM $$UNDEF_LST $(__OBJS) \
> > > 
> > > Hm.... we use UNDEF_SYM and UNDEF_LST in exactly the same way?  The
> > > 
> > > why cannot we do this all in a single run, like:
> > > 	UNDEF_SYM=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \
> > > 	sed  -n -e 's/.*\($(SYM_PREFIX)__u_boot_cmd_.*\)/-u\1/p' \
> > > 	
> > > 		-e 's/.*\($(SYM_PREFIX)_u_boot_list_.*\)/-u\1/p' | sort | uniq`;
> > 
> > \
> > 
> > > 	cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) $$UNDEF_SYM $(__OBJS)
> > > 	\ ...
> > > 
> > > ?
> > 
> > See above, otherwise I do agree.
> 
> It's not a big deal, in the end.  But, why can't you dump the file once
> and pass two regexps to sed rather than dump it twice, regex it twice
> and reference two variables?

I can ... shall I redo the patches just for the heck of it with no obvious 
benefit at all ... when the $$UNDEF_SYM is removed in 5/5 anyway?

Best regards,
Marek Vasut