[U-Boot] [PATCH V3 2/5] ARM: enhance u-boot.lds to detect over-sized SPL

Tom Rini trini at ti.com
Mon Oct 22 19:52:12 CEST 2012


On Mon, Oct 22, 2012 at 10:19:33AM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren at nvidia.com>
> 
> Add an ASSERT() to u-boot.lds to detect an SPL that doesn't fit within
> SPL_TEXT_BASE..SPL_MAX_SIZE.
> 
> Different .lds files implement this check in two possible ways:
> 1) An ASSERT() like this
> 2) Defining a MEMORY region of size SPL_MAX_SIZE, and re-directing all
>    linker output into that region. Since u-boot.lds is used for both
>    SPL and main U-Boot, this would entail only sometimes defining a
>    MEMORY region, and only sometimes performing that redirection, and
>    hence option (1) was deemed much simpler, and hence implemented.
> 
> Note that this causes build failures at least for NVIDIA Tegra Seaboard
> and Ventana. However, these are legitimate; the SPL doesn't fit within
> the required space, and this does cause runtime issues.
> 
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> Acked-by: Simon Glass <sjg at chromium.org>
> Acked-by: Allen Martin <amartin at nvidia.com>

This isn't quite what I envisoned at first (see 
arch/arm/cpu/armv7/omap-common/u-boot-spl.lds) but I think for the
generic linker script, this is the least instrusive method.

Acked-by: Tom Rini <trini at ti.com>

And since parts 1 and 2 are generic code, I've assigned them to Albert
in patchwork.  It's his call if he wants to take them or have them all
come via the tegra tree.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121022/6f8eca56/attachment.pgp>


More information about the U-Boot mailing list