[U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

Marek Vasut marex at denx.de
Wed Oct 24 22:17:11 CEST 2012


Dear Allen Martin,

[...]

> > [...]
> > 
> > Good, now please fix the bug. I'm terribly unhappy seeing there is a bug
> > that is about to go unfixed.
> 
> I didn't say the bug will go unfixed, I've opened an issue in our
> internal bug tracker so it doesn't go forgotten.  It's just a matter
> of prioritization.

Yes, the bug is really simple to fix, so instead of arguing, please get to work. 
It could have been fixed already!

> It's just not important to fix a corner case bug

I'm sorry, I really need to be careful with wording here. I'm always baffled how 
an engineer can ignore a bug.

> in a driver that noone outside of NVIDIA can actually use when there
> are major functionality holes and regressions (like your change to
> serial_assign() that broke serial output on tegra).

Stop being personal, this hurts and doesn't help. Care to send a patch for this? 
I don't have a working tegra setup (yet), but you can test this. I already 
outlined the fix, so it's just a matter to implement it.

> I only work on
> u-boot on the side, so I have to pick my battles carefully.

I'm glad for any contribution from your end, don't be mistaken. I really 
appreciate it, sorry if my working is sometimes way too blunt or heartless.

> -Allen

Best regards,
Marek Vasut


More information about the U-Boot mailing list