[U-Boot] [PATCH 2/2] mmc: Split device init to decouple OCR-polling delay

[Simon Glass]

Hi,

On Sun, Oct 21, 2012 at 1:12 AM, RgC <sessyargc at gmail.com> wrote:
> Hi All,
>
> On 2012.10/20, Simon Glass wrote:
>> From: Che-Liang Chiou <clchiou at chromium.org>
>>
>> Most of time that MMC driver spends on initializing a device is polling
>> OCR (operation conditions register).  To decouple this polling loop,
>> device init is split into two parts: The first part fires the OCR query
>> command, and the second part polls the result.  So the caller is now no
>> longer bound to the OCR-polling delay; he may fire the query, go
>> somewhere and then come back later for the result.
>>
>> To use this, call mmc_set_preinit() on any device which needs this.
>>
>> This can save significant amounts of time on boot (e.g. 200ms) by
>> hiding the MMC init time behind other init.
>>
>
> Please note that this patch has a conflict with the patch from Kim Phillips'
> [U-Boot,28/32] drivers/mmc/mmc.c: sparse fixes (191937 in patchworks)
>
> I had to apply this patch first before patching Kim's modifications which
> succeeds with the hunk offsets adjusted. It builds OK with the eldk 5.2.1
> for powerpc. Will test these on an ml507 when I have time.

Yes I found the same. In fact Kim's patches don't apply to master for me.

co upstream/master
Note: checking out 'upstream/master'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 186fc4d... ColdFire: Add Freescale MCF54418TWR ColdFire
development board support
 ~/u> patch -p1 <~/Downloads/U-Boot-28-32-drivers-mmc-mmc.c-sparse-fixes.patch
patching file drivers/mmc/mmc.c
Hunk #1 succeeded at 47 with fuzz 2 (offset -87 lines).
Hunk #2 succeeded at 109 (offset -92 lines).
Hunk #3 succeeded at 153 (offset -92 lines).
Hunk #4 succeeded at 346 (offset -92 lines).
Hunk #5 succeeded at 417 (offset -92 lines).
Hunk #6 succeeded at 438 (offset -92 lines).
Hunk #7 succeeded at 503 (offset -92 lines).
Hunk #8 succeeded at 567 (offset -92 lines).
Hunk #9 succeeded at 589 (offset -92 lines).
Hunk #10 succeeded at 611 (offset -92 lines).
Hunk #11 succeeded at 681 (offset -92 lines).
Hunk #12 succeeded at 702 (offset -92 lines).
Hunk #13 succeeded at 841 (offset -92 lines).
Hunk #14 succeeded at 859 (offset -92 lines).
Hunk #15 succeeded at 1014 (offset -92 lines).
Hunk #16 succeeded at 1149 (offset -92 lines).

Regards,
Simon

>
> Regards,
> Rommel
>