[U-Boot] [PATCH] usb: tegra: move Tegra EHCI implementation to correct place

Lucas Stach dev at lynxeye.de
Fri Oct 26 09:29:30 CEST 2012


Hi Marek,

Am Freitag, den 26.10.2012, 09:09 +0200 schrieb Marek Vasut:
> Dear Lucas Stach,
> 
> > Move the Tegra EHCI implementation to the correct directory in the tree.
> > This code is specific to the Tegra EHCI controller, not to the Tegra SoC
> > in general.
> > 
> > This is not just a move of the code, but also some small changes squashed
> 
> Unsquash them please, it's really hard to review. Also, use git format-patch -M 
> -C to generate the patchset and to detect renames.
> 
I've generated the patch with format-patch -B -M -C, so what you see is
basically the diff of the original file with the new implementation. So
the diff shows all the small changes I blather about.

The changes are squashed in because I did them while moving the
implementation over, and I would like to avoid doing them in single
patches as it's notably more work and IMHO with the current diff you can
clearly see what changed. So please let me know if you are really that
keen to have them as separate patches, but it may take me some while to
respin this as I'm occupied with other things right now.

Thanks,
Lucas
> > in. Most notable:
> > - removed some unneeded parameters from function calls, to make functions
> >   more self contained
> > - decrease max controller count to 3, both Tegra 2 and 3 have at most 3
> >   EHCI controllers, we can aleays increase this later if the need arises
> > - controllers only get activated at ehci_hcd_init time, not at
> > board_usb_init, which is the more obvious init point and saves time if you
> > are not going to use usb in your boot process at all
> [...]
> Best regards,
> Marek Vasut
> 




More information about the U-Boot mailing list