[U-Boot] [PATCH V3 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL

[Stephen Warren]

On 10/27/2012 03:15 AM, Albert ARIBAUD wrote:
> Hi Stephen,
> 
> On Mon, 22 Oct 2012 10:19:36 -0600, Stephen Warren
> <swarren at wwwdotorg.org> wrote:
> 
>> From: Stephen Warren <swarren at nvidia.com>
>>
>> Seaboard has a GPIO that switches an external mux between Tegra's debug
>> UART and SPI flash. This is initialized from the SPL so that SPL debug
>> output can be seen. Simplify the code that does this, and don't actually
>> request the GPIO in the SPL; just program it. This saves ~4.5K from the
>> size of the SPL, mostly BSS due to the large gpio_names[] table that is
>> no longer required. This makes Seaboard's SPL fit within the current max
>> size.
> 
> Is it possible to reorder the patch series so that Seaboard (and
> Ventana?) builds do not break temporarily between patch 2 and this
> patch?

It would be possibel, although I'd personally rather call out the issue
explicitly with a build break; if the build succeeds, you end up using
code that silently causes memory corruption. Of course, this issue has
been around for a while, so perhaps hiding it for another couple extra
commits wouldn't be a big deal. Plus, the build break proves the assert
in the .lds file works:-) But it's not big deal either way; feel free to
re-order the commits if you want.