[U-Boot] [PATCH v3 21/22] ide: Correct function signatures for ide_read/write()

Tom Rini trini at ti.com
Mon Oct 29 19:22:43 CET 2012


On Mon, Oct 29, 2012 at 08:24:04AM -0700, Simon Glass wrote:

> The prototypes in the header were changed by commit 4ac8f8e0 but the
> functions no longer match. Correct this.

Oops, not sure how I missed that.

> It seems odd that block devices take an lbaint_t for the block count, but
> an unsigned long for the blknr. Surely we should promote blknr to lbaint_t
> also?

It's a bit odd, I agree but doc/driver-model/UDM-block.txt promises to
correct this so I went first for consistency in all users.

Reviewed-by: Tom Rini <trini at ti.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121029/a7c7a89a/attachment.pgp>


More information about the U-Boot mailing list