[U-Boot] [PATCH v6 1/7] powerpc: Extract EPAPR_MAGIC constants into processor.h

Wolfgang Denk wd at denx.de
Tue Oct 30 11:04:24 CET 2012


Dear Stefan Roese,

In message <1351590321-20368-1-git-send-email-sr at denx.de> you wrote:
> By extracting these defines into a header, they can be re-used by other
> C sources as well. This will be done by the SPL framework OS boot
> support.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
> Changes in v6:
> - Fix compile warning: release.S:354:0: warning: "EPAPR_MAGIC" redefined

Please re-read
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

You are supposed to provide a _history_ of changes here, but instead
you describe only the latest change.  This is not how it's suppoosed
to be done.

Also, your submission includes neither any "In-reply-to:" nor any
"References:" header, i. e. there is no way to match it to any
previous mail thread.  This is very bad.  How are we supposed to know
what you are actually talking about, or where we would find any of the
previous patches or the other 6 patches of this series?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Es ist offensichtlich, dass das menschliche Gehirn wie  ein  Computer
funktioniert.  Da  es  keine  dummen Computer gibt, gibt es also auch
keine dummen Menschen. Nur ein paar Leute, die unter DOS laufen.
                                                       -- <unbekannt>


More information about the U-Boot mailing list