[U-Boot] [PATCH v7 0/16] tegra: Add display driver and LCD support for Seaboard

[Simon Glass]

Hi Tom,

On Tue, Oct 30, 2012 at 3:43 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Tom,
>
> On Tue, Oct 30, 2012 at 2:19 PM, Tom Warren <TWarren at nvidia.com> wrote:
>> Simon,
>>
>>> -----Original Message-----
>>> From: Tom Warren
>>> Sent: Tuesday, October 30, 2012 12:24 PM
>>> To: 'Simon Glass'; U-Boot Mailing List
>>> Cc: Stephen Warren
>>> Subject: RE: [PATCH v7 0/16] tegra: Add display driver and LCD support for
>>> Seaboard
>>>
>>> Simon,
>>>
>>> > -----Original Message-----
>>> > From: Simon Glass [mailto:sjg at chromium.org]
>>> > Sent: Wednesday, October 17, 2012 4:25 PM
>>> > To: U-Boot Mailing List
>>> > Cc: Stephen Warren; Tom Warren; Simon Glass
>>> > Subject: [PATCH v7 0/16] tegra: Add display driver and LCD support for
>>> > Seaboard
>>> >
>>> > This series adds support for the Tegra2x's display peripheral. This
>>> > supports the LCD display on Seaboard and we use this to enable console
>>> > output in U- Boot on the LCD.
>>>
>>> Applied to tegra/next and pushed to denx.de. ./MAKEALL -s tegra20 is OK,
>>> checkpatch is clean. Thanks.
>>>
>>> I'll do some testing on my Seaboard while I run a ./MAKEALL -a arm.
>>
>> The above MAKEALL build (arm) fails on the Lubbock, zipitz2, palmld and palmtc builds with the following error:
>>
>> common/libcommon.o: In function `lcd_sync':
>>  /common/lcd.c:125: undefined reference to `flush_dcache_range'
>>
>> These builds use the 'pxa' arm cpu type, and perhaps don't have an implementation of the dcache routines.
>>
>> I'll need a fix before I can submit a pull request to Albert for this.
>>
>> Note that there are a couple of other arm builds (tx25 mx31pdk) that also fail, but not due to any Tegra or LCD reason - it appears they fail in arm/master, too, so they can be ignored for now.
>
> Ah ok. I will take a look.

OK, I found that pxa doesn't have this function. Some boards define
CONFIG_SYS_DCACHE_OFF and some don't.

So I have amended one of the LCD commits to look for that, and resent it.

http://patchwork.ozlabs.org/patch/195663/

I have also created a commit to update  zipitz2, palmtc and palmld to
define CONFIG_SYS_DCACHE_OFF. I hope that is acceptable to the
maintainer.

http://patchwork.ozlabs.org/patch/195662/

Regards,
Simon