[U-Boot] [[Patch V2] mips: 01/16] add mips64 standalone support

[Wolfgang Denk]

Dear Zhizhou Zhang,

In message <1345217476-32034-2-git-send-email-etou.zh at gmail.com> you wrote:
> Daniel Schwierzeck told me to do it with macro, But it seems not
> work. For u-boot.lds was genarete by gcc. It's hard to do that
> without a lot modify.
> ---
>  arch/mips/config.mk |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/mips/config.mk b/arch/mips/config.mk
> index 6ab8acd..56996cc 100644
> --- a/arch/mips/config.mk
> +++ b/arch/mips/config.mk
> @@ -23,7 +23,11 @@
>  
>  CROSS_COMPILE ?= mips_4KC-
>  
> +ifeq "$(CPU)" "mips64"
> +CONFIG_STANDALONE_LOAD_ADDR ?= 0xFfffFfff80200000 -T mips64.lds

Please use a consistent style, use all uper or all lower case
letters, i. e. make this 0xffffffff80200000 or 0xFFFFFFFF80200000.

Aloso, please make sure your patches are bisectable.  This change adds
a reference to mips64.lds, but does not add this file.  That's bad.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Space is big. You just won't believe how vastly, hugely, mind-
bogglingly big it is. I mean, you may think it's a long way down the
road to the drug store, but that's just peanuts to space.
                              -- The Hitchhiker's Guide to the Galaxy