[U-Boot] [Patch V4 1/4] MIPS: Add support for MIPS64 cpus

[Wolfgang Denk]

Dear Zhizhou Zhang,

In message <1346071750-6634-7-git-send-email-etou.zh at gmail.com> you wrote:
> These files are derived from arch/mips/cpu/mips32/*. The main changes are:
> 1, changes ABI o32 to n64, 2, add mips64 build cflags.
> 
> Signed-off-by: Zhizhou Zhang <etou.zh at gmail.com>

Checkpatch reports a number of "unnecessary whitespace before a quoted
newline" warnings; please fix these.

> diff --git a/arch/mips/cpu/mips64/Makefile b/arch/mips/cpu/mips64/Makefile
> new file mode 100644
> index 0000000..f4c88f5
> --- /dev/null
> +++ b/arch/mips/cpu/mips64/Makefile
...
> +sinclude $(obj).depend
> +
> diff --git a/arch/mips/cpu/mips64/cache.S b/arch/mips/cpu/mips64/cache.S

Please do not add trailing empty lines.  Please fix globally.

...
> +++ b/arch/mips/cpu/mips64/config.mk
> @@ -0,0 +1,40 @@
...
> +CONFIG_STANDALONE_LOAD_ADDR ?= 0xFfffFfff80200000 -T mips64.lds

As requested before: please don't mix upper and lower case letters in
a number; use a consistent styile everywhere. PLease fix globally.


As requested before: please make sure your patches are bisectable.
This references file mips64.lds, but doesn;t add it, so it cannot
work.

...
> +#define cache_op(op, addr)						\
> +	__asm__ __volatile__(						\
> +	"	.set	push					\n"	\
> +	"	.set	noreorder				\n"	\
> +	"	.set	mips64\n\t				\n"	\
> +	"	cache	%0, %1					\n"	\
> +	"	.set	pop					\n"	\

Fix checkpatch warnings here (and globally).

> +	while (1) {
> +		cache_op(Hit_Writeback_Inv_D, addr);
> +		cache_op(Hit_Invalidate_I, addr);

We don't allow camel-case identifiers.  Please fix globally.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it has syntax, it isn't user friendly.