[U-Boot] [Patch V4 3/4] MIPS: add board qemu-mips64 support

[Wolfgang Denk]

Dear Zhizhou Zhang,

In message <1346071750-6634-9-git-send-email-etou.zh at gmail.com> you wrote:
> Both big-endian and little-endian are tested with below commands:
> qemu-system-mips64el -M mips -cpu MIPS64R2-generic -kernel u-boot -nographic
> qemu-system-mips64 -M mips -cpu MIPS64R2-generic -kernel u-boot -nographic
...
> +/*IP address is default used by Qemu*/
> +#define CONFIG_IPADDR		10.0.2.15	/* Our IP address */
> +#define CONFIG_SERVERIP		10.0.2.2	/* Server IP address */

NAK.  We don't allow static network settings in board config files.
Please remove.


> +#define CONFIG_BOOTCOMMAND	""

This makes no sense. Please fix or omit.

...
> +#define CONFIG_DRIVER_NE2000_BASE	(0xffffffffb4000300)

Please remove parens around simple numbers.  Please fix globally.

> +#define CONFIG_ENV_IS_NOWHERE		1

Please don't define values for logical variables.  Please fix
globally.

> +#undef CONFIG_MEMSIZE_IN_BYTES

Please don't undef what is not defined anyway.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the realm of scientific observation, luck is granted only to those
who are prepared.                                     - Louis Pasteur