[U-Boot] [PATCH] [RFC] powerpc: re-add bi_ip_addr to bd_t struct
Wolfgang Denk
wd at denx.de
Sun Sep 2 22:35:34 CEST 2012
Dear Anatolij Gustschin,
In message <1346612940-8580-1-git-send-email-agust at denx.de> you wrote:
> Since commit 50a47d0523e8efebe912bef539a77ffd42116451
> (net: punt bd->bi_ip_addr) booting old 2.4.x ppc kernels
> is broken due to changed offsets of the fields in struct bd_t.
> Offsets of the fields after removed bi_ip_addr are wrong,
> causing wrong bus clocks and console baudrate configurations
> and various other issues. Re-add the bi_ip_addr field to preserve
> backward compatibility with older ppc kernels. Setting bi_ip_addr
> in board.c is not really needed, grepping in the 2.4 linux tree
> shows that bi_ip_addr is not accessed there. Adding bi_ip_addr
> to struct bd_t for other arches isn't needed it seems. bd_t is
> not used by other arches in the 2.4 linux tree.
>
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> ---
> arch/powerpc/include/asm/u-boot.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Acked-by: Wolfgang Denk <wd at denx.de>
Good catch, thanks! I'll pick this up right now...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A supercomputer is a machine that runs an endless loop in 2 seconds.
More information about the U-Boot
mailing list