[U-Boot] [PATCH 1/3] disk: part_efi: parse and store partition UUID

Stephen Warren swarren at wwwdotorg.org
Mon Sep 3 04:06:32 CEST 2012


On 09/02/2012 10:45 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <1345158942-31512-1-git-send-email-swarren at wwwdotorg.org> you wrote:
>> From: Stephen Warren <swarren at nvidia.com>
>>
>> Each EFI partition table entry contains a UUID. Extend U-Boot's struct
>> disk_partition to be able to store this information, and modify
>> get_partition_info_efi() to fill it in.
>>
>> The implementation of uuid_string() was stolen from the Linux kernel.
>>
>> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> 
> Can we please make this addition dependent on EFI support being
> enabled?  Otherwise the increased memory footprint will hit all users,
> even if they never use EFI at all.

(I assume you're talking about the change to the partition info
structure, since IIRC all the other code was already in either the EFI
partition code already, or a new command under its own ifdef).

I'm also planning a patch that fills in this UUID field for MBR/DOS
partition tables too. That'd require the ifdef to check 2 different
config symbols, and perhaps more in the future. It seems a little messy
to ifdef this just to save 4 bytes. Are you sure you want to do this?



More information about the U-Boot mailing list