[U-Boot] [PATCH] mtest: Disable dcache during test

[Wolfgang Denk]

Dear Graeme Russ,

In message <CALButCLVW0Vv9vc+MZ0wpau2xw7FPv+ZqpD7MZpxn=K_400HVA at mail.gmail.com> you wrote:
> 
> > If this line is overlooked, it's the same as not having it. If it is not
> > overlooked, it is useful both to detail the test conditions and as a reminder
> > not to do stupid things. This line does not prevent users from doing any manual
> > dcache check/enable/disable operation they want before running mtest. All in
> > all, adding this line can only be beneficial.

I disagree. It add line noise, printing information that is available
otherwise as well.

If you are interested in the state of the data cache support, just run
the "dcache" command.

> I'm also inclined to not 100% trust dcache operations (we all know
> that cache support is in a state of flux) so something like:
>
> # dcache on
> # mtest 0x80100000 0x90000000 0xaabb
...
> You know something is wrong with the dcache on implementation

Well, it appears awkward to me to use a completely unrelated command
for such "testing".  The same result should be available (much more
straightforward) with:

	# dcache on
	# dcache


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The word "fit", as I understand it, means "appropriate to a purpose",
and I would say the body of the Dean is supremely appropriate to  the
purpose of sitting around all day and eating big heavy meals.
                                 - Terry Pratchett, _Moving Pictures_