[U-Boot] [PATCH 0/4] USB multi controller

Stephen Warren swarren at wwwdotorg.org
Wed Sep 5 21:11:36 CEST 2012


On 09/05/2012 12:30 AM, Marek Vasut wrote:
> Dear Lucas Stach,
> 
>> Hi Stephen,
>>
>> Am Dienstag, den 04.09.2012, 17:05 -0600 schrieb Stephen Warren:
>>> On 08/30/2012 10:03 AM, Lucas Stach wrote:
>>>> Hi all,
>>>>
>>>> this is a follow up on the patch "USB: EHCI: Initialize multiple
>>>> USB controllers at once" from Jim Lin. It takes some of the
>>>> code but has undergone some heavy reworking.
>>>>
>>>> When we remove the ifdef horror from the above mentioned patch it's
>>>> mostly a big interface change to the usb subsystem. As this creates
>>>> a lot of churn I've split this up into a series. Every patch is self
>>>> contained so it doesn't break compiles and *should* not regress
>>>> any functionality on it's own. At least the series is bisectable in
>>>> case anything goes wrong. I've compile tested all the ARM configs.
>>>>
>>>> Both the lowlevel usb and ehci interface change are backward
>>>> compatible, so implementations that only use one controller can
>>>> choose to ignore the new interface. All implementations are
>>>> updated to work with the new function prototypes.
>>>>
>>>> For Tegra I've included a patch to actually use the new ehci
>>>> interface. Patches are based on a Tegra tree with some relevant
>>>> changes from u-boot-usb picked over, so they should apply to
>>>> u-boot-usb/master.
>>>
>>> Can you explain what this series is based on in a little more detail? I
>>> tried applying it to Tegra's for-next today, and it wouldn't apply. I
>>> managed to apply using plain "patch" rather then "git am", but then I
>>> get a bunch of compile errors:-(
>>
>> At the time I wrote those patches the u-boot-usb and u-boot-tegra trees
>> didn't merge cleanly and I wasted quite some time trying to fix up the
>> failed merge. In the end I ended up just picking the following over to
>> my tegra tree, which should be enough to avoid any conflicts with the
>> usb tree:
>>
>> cdeb916120a4 ehci: cosmetic: Define the number of qt_buffers
>> 44ae0be7461f ehci: Fail for multi-transaction interrupt transfers
>> 14eb79b7a086 ehci: cosmetic: Define used constants
>> 5cec214ecd7d ehci-hcd: Boost transfer speed
>> cffcc5035809 usb_storage: Restore non-EHCI support
>> 4bee5c83ea46 usb_storage: Remove EHCI constraints
>> 3e8581bb9589 usb_stor_BBB_transport: Do not delay when not required
>> db19134615dd ehci: Optimize qTD allocations
> 
> u-boot-usb master is updated to master and pushed for your enjoyment.

The series doesn't appear to apply to u-boot-usb/master, nor to
u-boot-tegra/master plus those cherry-picks listed above. Perhaps you
can rebase on something (although I'm not sure which branch it's meant
to go through) so I can apply/test it?


More information about the U-Boot mailing list