[U-Boot] Commit 67cbbf2... breaks some ARM builds

Albert ARIBAUD albert.u.boot at aribaud.net
Thu Sep 6 09:49:17 CEST 2012


Hello,

While merging u-boot/master and u-boot-arm/master in preparation of a
pull requst, I saw that commit 67cbbf2... ("mmc: Remove unused item
flags in struct mmc_cmd") breaks several arm builds such as palmld:

$ LANG=C ./MAKEALL palmld
Configuring for palmld board...
pxa_mmc_gen.c:121:9: error: 'struct mmc_cmd' has no member named 'flags'
pxa_mmc_gen.c:184:47: error: 'struct mmc_cmd' has no member named
'flags'
pxa_mmc_gen.c:186:10: error: 'struct mmc_cmd' has no member named
'flags'
make[1]: *** [pxa_mmc_gen.o] Error 1
make: *** [drivers/mmc/libmmc.o] Error 2
arm-linux-gnueabi-size: './u-boot': No such file
pxa_mmc_gen.c: In function 'pxa_mmc_start_cmd':
pxa_mmc_gen.c:121:9: error: 'struct mmc_cmd' has no member named 'flags'
pxa_mmc_gen.c: In function 'pxa_mmc_cmd_done':
pxa_mmc_gen.c:184:47: error: 'struct mmc_cmd' has no member named
'flags'
pxa_mmc_gen.c:186:10: error: 'struct mmc_cmd' has no member named
'flags'
make[1]: *** [pxa_mmc_gen.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers/mmc/libmmc.o] Error 2
make: *** Waiting for unfinished jobs....

--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with errors: 1 ( palmld )
----------------------------------------------------------

Apparently, either the commit overlooked some ARM boards when
considering 'flags' were unused, or it did not remove all references to
flags throughout the code base.

Kapster, can you post a fix or revert?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list