[U-Boot] [PATCH 0/6] add zip command support for uboot

[Lukasz Majewski]

Hi Marek,

> Dear Lukasz Majewski,
> 
> > Dear Marek and Lei,
> > 
> > > Dear Lei Wen,
> > > 
> > > > Hi Marek,
> > > > 
> > > > On Thu, Sep 6, 2012 at 12:18 PM, Marek Vasut
> > > > 
> > > > <marek.vasut at gmail.com> wrote:
> > > > > Dear adrian.wenl at gmail.com,
> > > > > 
> > > > >> From: Lei Wen <leiwen at marvell.com>
> > > > > 
> > > > > Lei? Long time no see :)
> > > > 
> > > > Long time no see. :)
> > > 
> > > Yep, you're doing well?
> > > 
> > > > >> This patch set add zip command support for uboot.
> > > > >> The first two patches import deflate and trees functions from
> > > > >> zlib 1.2.5 without any change. While the third patch did the
> > > > >> necessary change to make the import file could be built
> > > > >> passed in uboot environment.
> > > > >> 
> > > > >> The fourth patch make us could zip the memory from 0 in the
> > > > >> address space.
> > > > >> 
> > > > >> The latter fifth and sixth patch does the adding gzip lib
> > > > >> function exporting and zip command support.
> > > > >> 
> > > > >> Patch set test with zip&unzip and compared with original
> > > > >> memory content.
> > > > >> 
> > > > >> Lei Wen (6):
> > > > >>   lib: zlib: import deflate source file from 1.2.5
> > > > >>   lib: zlib: import trees file from 1.2.5
> > > > >>   lib: zlib: include deflate into zlib build
> > > > >>   lib: zlib: remove the limitation for cannot using 0 as
> > > > >> start lib: add gzip lib function callback
> > > > >>   common: add zip command support
> > > > >>  
> > > > >>  common/Makefile       |    1 +
> > > > >>  common/cmd_zip.c      |   60 ++
> > > > >>  include/common.h      |    7 +
> > > > >>  include/u-boot/zlib.h |   40 +-
> > > > >>  lib/Makefile          |    1 +
> > > > >>  lib/gzip.c            |  143 ++++
> > > > >>  lib/zlib/deflate.c    | 1831
> > > > >> 
> > > > >> +++++++++++++++++++++++++++++++++++++++++++++++++
> > > > >> lib/zlib/deflate.h | 342 +++++++++
> > > > >> 
> > > > >>  lib/zlib/trees.c      | 1244
> > > > >> +++++++++++++++++++++++++++++++++ lib/zlib/trees.h      |
> > > > >> 128 ++++ lib/zlib/zlib.c       |    8 +
> > > > >>  lib/zlib/zutil.h      |    4 +
> > > > >>  12 files changed, 3804 insertions(+), 5 deletions(-)
> > > > >>  create mode 100644 common/cmd_zip.c
> > > > >>  create mode 100644 lib/gzip.c
> > > > >>  create mode 100644 lib/zlib/deflate.c
> > > > >>  create mode 100644 lib/zlib/deflate.h
> > > > >>  create mode 100644 lib/zlib/trees.c
> > > > >>  create mode 100644 lib/zlib/trees.h
> > > > > 
> > > > > Are there any users for this code? What is it for ?
> > > > 
> > > > This patch was intended to compress the memory when uploading
> > > > through USB. So that uploaded image could be smaller.
> > > > Maybe there are some other usage, like memory testing?
> > > 
> > > CCing Lukasz, maybe he can find some use for this in the DFU
> > > series?
> > 
> > I think, that there is a possibility to gzip the host DFU data and
> > uncompress it after USB transmission (especially when "zip" command
> > is available from command line).
> 
> Ok, that means we can make use of this command ?

I cannot promise, that I will provide the "zip" support straightaway in
the DFU.

On the one hand if DFU is the only user of this command we are adding in
fact a "dead" code.
On the other hand we can use proper #define CONFIG_CMD_ZIP to not
compile it until we "really" use this.

Are there any other potential "users" of this functionality (ZIP
compression/decompression) in u-boot?

-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group