[U-Boot] [NEXT PATCH v1 5/7] SPL: Added MLO for mx35 SOC to SPL Makefile

[stefano babic]

Am 06/09/2012 22:48, schrieb Tom Rini:
> On 09/06/2012 12:59 PM, Stefano Babic wrote:
>> On 06/09/2012 19:49, Tom Rini wrote:
>>> On 09/06/2012 01:04 AM, Stefano Babic wrote:
>>>> Signed-off-by: Stefano Babic <sbabic at denx.de>
>>>> ---
>>>>  spl/Makefile |    6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/spl/Makefile b/spl/Makefile
>>>> index f96c08e..77fc405 100644
>>>> --- a/spl/Makefile
>>>> +++ b/spl/Makefile
>>>> @@ -109,6 +109,12 @@ $(OBJTREE)/MLO:	$(obj)u-boot-spl.bin
>>>>  		-a $(CONFIG_SPL_TEXT_BASE) -d $< $@
>>>>  endif
>>>>  
>>>> +ifneq ($(CONFIG_IMX_CONFIG),)
>>>> +$(OBJTREE)/MLO:	$(obj)u-boot-spl.bin
>>>> +	$(OBJTREE)/tools/mkimage -n  $(SRCTREE)/$(CONFIG_IMX_CONFIG) -T imximage \
>>>> +		-e $(CONFIG_SPL_TEXT_BASE) -d $< $@
>>>> +endif
>>>> +
>>>>  ALL-y	+= $(obj)u-boot-spl.bin
>>>>  
>>>>  ifdef CONFIG_SAMSUNG
>>>
>>> Is that really the name you want?  MLO comes from some part or another
>>> (I've read it, just can3't recall off-hand) of the IT ROM docs saying it
>>> will read a file named MLO.
>>
>> I know...
>>
>>>  Is mx35 in the same boat?
>>>  Or just looking
>>> for a common name?  
>>
>> Right. It makes no sense that the binary for Freescale's SOCs has a
>> name, for TI another one, for...we can generates less confusion if we
>> uses the same name.
> 
> Agreed.  I guess what I'm asking is, in the TI case the ROM reads FAT
> and must find 'MLO'.  Does mx35 do the same or

No. And not only the MX35, but also the MX5/MX6.

> is the post-build step
> "dd if=MLO of=/dev/... ..." and the filename doesn't matter?

Exactly. The ROM does not understand a filesystem, and the SPL must be
stored at a fixed address in the SD card. The filename does not matter,
and the SPL is not seen as file, but as a raw image.

>  I'm fine
> with the change now, just looking for the full details.  Thanks!

As for Freescale the filename does not matter while for TI does, we can
use for both MLO ;-)

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================