[U-Boot] [PATCH] mx6qsabresd: Add basic support

[stefano babic]

Am 11/09/2012 05:56, schrieb Fabio Estevam:
> Hi Stefano,
> 

Hi Fabio,

> On Thu, Apr 12, 2012 at 7:52 AM, Stefano Babic <sbabic at denx.de> wrote:
> 
>> This file is identical to imximage.cfg for the mx6qsabrelite board. I
>> can imagine this is derived board. Why cannot we implement it as a
>> variant of the original one ? We have several example in u-boot, for
>> example the efika (MX51), or the TAM3517 (ok, I admit I know this very
>> well because I did it...), or imx27-lite /magnesium, or....
> 
> After a long time, I am returning on adding support to mx6qsabresd.
> 
> I have been comparing mx6qsabrelite against mx6qsabresd and I have
> started to do as you suggested: unify the 2 boards into
> mx6qsabrelite.c.
> 
> What I realize is that the differences are relevant: UART1 pin muxing,
> SDHC ports, SDHC card detect GPIO, USB Host enable port, I2C devices,
> Ethernet PHY, etc.

Of course, unifying boards makes sense if the two boards are very similar.


> 
> It seems to me that the code is becoming polluted by all the ifdef's I
> need to place in order to handle both boards, and I am starting to
> think if it wouldn't be better to follow with the original approach of
> adding a board/freescale/mx6qsabresd directory.
> 
> After I finish mx6qsabresd, I also plan to add one more mx6q board,
> and this would mean even more ifdefs, which would make the code even
> harder to read.

Absolutely. I let you to decide if some code can be shared, but if you
see such a lot of differences, go on with a separate board.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================