[U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

[Marek Vasut]

Dear Michal Simek,

> On 09/13/2012 02:32 PM, Marek Vasut wrote:
> > Dear Michal Simek,
> > 
> >> On 09/13/2012 12:31 PM, Marek Vasut wrote:
> >>> Dear Michal Simek,
> >>> 
> >>>> On 09/13/2012 11:31 AM, Marek Vasut wrote:
> >>>>> Dear Michal Simek,
> >>>>> 
> >>>>> [...]
> >>>>> 
> >>>>>> +#include <config.h>
> >>>>>> +#include <linux/linkage.h>
> >>>>>> +
> >>>>>> +ENTRY(lowlevel_init)
> >>>>>> +        mov     pc, lr
> >>>>>> +ENDPROC(lowlevel_init)
> >>>>> 
> >>>>> inline void lowlevel_init(void) {} works as well and you don't need
> >>>>> the assembly file.
> >>>>> 
> >>>> :-) yes. The reason why I have done it in this way that we have some
> >>>> :asm code
> >>>> 
> >>>> which will go to this area. That's why I have kept it in asm instead
> >>>> of C.
> >>> 
> >>> What code? Will the code go into lowlevel_init() ?
> >> 
> >> For example SLCR locking if is not locked from the first stage
> >> bootloader. Also if necessary OCM and DDR remap, FPGA reset can be also
> >> there based on configuration.
> > 
> > Can it not be in C code ?
> 
> Probably can be in C code. I have no problem to move it to C.

Please do, cut the assembly to minimum.

> Cheers,
> Michal

Best regards,
Marek Vasut