[U-Boot] [PATCH 1/9] Tegra: T30: Add include files
Tom Rini
trini at ti.com
Thu Sep 13 20:06:09 CEST 2012
On Wed, Sep 12, 2012 at 03:10:47PM -0700, Tom Warren wrote:
> Signed-off-by: Tom Warren <twarren at nvidia.com>
A few things:
- I see some #define FOO[space][space]val that should be [tab]
- I didn't checkpatch.pl this (nor the whole series) but please do and
let us know if it's clean or why the warnings are false positives.
- My preference is to bring in includes and C files and Makefiles and so
on all at once, when each is needed / useful. YMMV and not a big
deal.
- But please make sure that you aren't adding defines / structs / etc
that aren't used at some point by the end of the series at least.
Removing (and correcting!) structs and defines was one of the things I
had to do on am33xx. If it wasn't added until the corresponding
driver work was being pushed, it'd have saved me some time.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120913/1b9231ac/attachment.pgp>
More information about the U-Boot
mailing list